Skip to content

Conversation

@KSDaemon
Copy link
Member

Epoch datepart is not supported by Databricks. This PR fixes this by changing it to unix_timestamp().

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review January 30, 2025 09:42
@KSDaemon KSDaemon requested a review from a team as a code owner January 30, 2025 09:42
@KSDaemon KSDaemon requested a review from a team as a code owner January 30, 2025 11:43
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (92a4b8e) to head (752ac4b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9160      +/-   ##
==========================================
+ Coverage   83.16%   83.17%   +0.01%     
==========================================
  Files         226      226              
  Lines       80047    80096      +49     
==========================================
+ Hits        66570    66620      +50     
+ Misses      13477    13476       -1     
Flag Coverage Δ
cubesql 83.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon merged commit 9a73857 into master Jan 30, 2025
68 checks passed
@KSDaemon KSDaemon deleted the fix/datediff-databricks branch January 30, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants